2d neighbors #755
2d neighbors #755
Conversation
streeve
force-pushed
the
2d_neighbors
branch
5 times, most recently
from
4ca30da
to
ec1acc4
Compare
|
Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready. Also probably good to move those last two commits to a separate PR if you agree |
What do you mean by "good way to do the ArborX lists"? |
streeve
force-pushed
the
2d_neighbors
branch
2 times, most recently
from
6212f87
to
f481b33
Compare
Haven't tried yet, but I'd like to extract the dimension from the positions directly. Which would be nice across all cases honestly |
|
Looks mostly good to me, we should probably add tests of the 2D list capabilities as well which don't seem to be included |
streeve
force-pushed
the
2d_neighbors
branch
from
521a986
to
d832351
Compare
2d LinkedCellList CartesianGrid
2d neighbor discriminators
…lated functions/test
… for NeighborList
Requires View<scalar*[dim]>
|
@lebuller ready for another review - the new creation functions extract the dimension from the particles directly. You could still explicitly construct an object if those don't match if necessary |
Enable 2d neighbor construction and iteration. Dimension extracted from particle data in creation functions with default 3d template dimension in classes for backwards compatibility
Other notes:
Part of #490